Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm condition for read deployment is not defined #13947

Open
konck2 opened this issue Aug 22, 2024 · 0 comments
Open

Helm condition for read deployment is not defined #13947

konck2 opened this issue Aug 22, 2024 · 0 comments
Labels
area/helm type/bug Somehing is not working as expected

Comments

@konck2
Copy link

konck2 commented Aug 22, 2024

Describe the bug
There is no condition in Helm to check for read annotations .Values.read.annotations - https://github.com/grafana/loki/blob/helm-loki-6.6.2/production/helm/loki/templates/read/deployment-read.yaml#L12

To Reproduce
Steps to reproduce the behavior:

  1. Define .Values.read.annotations
  2. Apply deployment
  3. Read deployment don't have added annotations

Expected behavior
Annotations applied to read deployment
@JStickler JStickler added area/helm type/bug Somehing is not working as expected labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JStickler @konck2