Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki helm chart] Validation requires schemaConfig to be specified even if loki config is managed outside the chart #13878

Open
asherf opened this issue Aug 13, 2024 · 1 comment
Labels
area/helm type/bug Somehing is not working as expected

Comments

@asherf
Copy link

asherf commented Aug 13, 2024

Describe the bug
When using the option to set loki.configObjectName (and loki.generatedConfigObjectName) in order to manage the loki config from outside the loki chart (by creating a configmap and passing its name to the chart)
the validation here still requires the schemaConfig to be set, even though in this use case, it won't be actually used.

Expected behavior
If a loki.generatedConfigObjectName is empty (i.e. the loki chart does't create a loki configmap object) this validation should be short circuited.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: simply scalable

Screenshots, Promtail config, or terminal output

│ Error: execution error at (loki/templates/validate.yaml:40:4): You must provide a schema_config for Loki, one is not provided as this will be individual for every Loki cluster. See https://grafana.com/docs/loki/latest/operations/storage/schema/ for schema information. For quick testing (with no persistence) add --set loki.useTestSchema=true

@malekerramli
Copy link

im having the same exact issue using terraform

@JStickler JStickler added area/helm type/bug Somehing is not working as expected labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm type/bug Somehing is not working as expected
Projects
None yet
Development

No branches or pull requests

3 participants