Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser: go through codebase and figure out if contextcheck linter is right #4107

Open
mstoykov opened this issue Dec 12, 2024 · 0 comments
Open

browser: go through codebase and figure out if contextcheck linter is right #4107

mstoykov opened this issue Dec 12, 2024 · 0 comments
Labels
area: browser refactor

Comments

@mstoykov
Copy link
Contributor

As part of #4056 we disabled contextcheck in the browser code because there were way too many cases to be fixed.

Similar to #4094 the linter is likely not wrong all the time, but unfortunately due to the amount of occurances and the complexity it is likely going to take multiple iterations to fix the underlying code.
mstoykov added a commit that referenced this issue Dec 12, 2024
@mstoykov
Disable revive and contextcheck linters for browser code
c4b2ca8 
See #4107 for contextcheck

Revive also doesn't make as much sense for code that is not supposed to
be used directly by third parties, especially given the size of the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: browser refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mstoykov