You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current way to sign windows executables uses signtool which is part of windows kit. Unfortuantely it isn't in the path by default and the path to the exact location is dependant on the version of the windows kit.
Moving from windows-2019 to windows-2022 github action image meant that the path chagned and we had to fix it.
Given the information I found there doesn't seem to be a fix for this. If we ran from the terminal inside visual studio that sets the path correctly ... which doesn't seem like a good thing for a CI ;).
Luckily there aren't that many windows releases so hopefully we need to fix this once every 3-4 years, but it will still be nice if it isn't as brittle as it is.
The text was updated successfully, but these errors were encountered:
Originally posted by @olegbespalov in #4102 (comment)
The current way to sign windows executables uses
signtool
which is part of windows kit. Unfortuantely it isn't in the path by default and the path to the exact location is dependant on the version of the windows kit.k6/.github/workflows/build.yml
Lines 246 to 247 in ba6a71e
Moving from windows-2019 to windows-2022 github action image meant that the path chagned and we had to fix it.
Given the information I found there doesn't seem to be a fix for this. If we ran from the terminal inside visual studio that sets the path correctly ... which doesn't seem like a good thing for a CI ;).
Luckily there aren't that many windows releases so hopefully we need to fix this once every 3-4 years, but it will still be nice if it isn't as brittle as it is.
The text was updated successfully, but these errors were encountered: