Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the signtool usage in windows-packaging less brittle #4105

Open
mstoykov opened this issue Dec 12, 2024 · 0 comments
Open

Make the signtool usage in windows-packaging less brittle #4105

mstoykov opened this issue Dec 12, 2024 · 0 comments

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Dec 12, 2024

          This looks really brittle :thinking:

Originally posted by @olegbespalov in #4102 (comment)

The current way to sign windows executables uses signtool which is part of windows kit. Unfortuantely it isn't in the path by default and the path to the exact location is dependant on the version of the windows kit.

- name: Add signtool to PATH
run: echo "${env:ProgramFiles(x86)}\Windows Kits\10\bin\10.0.17763.0\x64" | Out-File -FilePath $env:GITHUB_PATH -Append

Moving from windows-2019 to windows-2022 github action image meant that the path chagned and we had to fix it.

Given the information I found there doesn't seem to be a fix for this. If we ran from the terminal inside visual studio that sets the path correctly ... which doesn't seem like a good thing for a CI ;).

Luckily there aren't that many windows releases so hopefully we need to fix this once every 3-4 years, but it will still be nice if it isn't as brittle as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants