Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: lint fixes #3561

Merged
merged 1 commit into from
Jan 31, 2024
Merged

lib: lint fixes #3561

merged 1 commit into from
Jan 31, 2024

Conversation

mstoykov
Copy link
Contributor

Part of #769

@mstoykov mstoykov added this to the v0.50.0 milestone Jan 24, 2024
@mstoykov mstoykov requested a review from a team as a code owner January 24, 2024 13:00
@mstoykov mstoykov requested review from codebien and joanlopez and removed request for a team January 24, 2024 13:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ef1f214) 72.82% compared to head (33d769e) 72.96%.
Report is 1 commits behind head on master.

❗ Current head 33d769e differs from pull request most recent head c9b2c1c. Consider uploading reports for the commit c9b2c1c to get more accurate results

Files Patch % Lines
lib/archive.go 60.00% 0 Missing and 2 partials ⚠️
lib/executor/externally_controlled.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3561      +/-   ##
==========================================
+ Coverage   72.82%   72.96%   +0.14%     
==========================================
  Files         278      280       +2     
  Lines       20947    20946       -1     
==========================================
+ Hits        15254    15284      +30     
+ Misses       4715     4692      -23     
+ Partials      978      970       -8     
Flag Coverage Δ
macos 72.89% <82.60%> (?)
ubuntu 72.92% <82.60%> (?)
windows 72.82% <82.60%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 4839e8d into master Jan 31, 2024
24 checks passed
@mstoykov mstoykov deleted the lintLib branch January 31, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants