-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize resulting request duration name #3403
Comments
Hey @bedefaced,
I'm not against this in principle, but they are a very important part of the product and a change to them will be a big change with a relevant impact. There are a lot of details to consider in a change like this, for example, if you have a test with both, how do you differentiate between them? If something like this will be implemented, I don't think is realistic to be considered before #1321 that introduces a granular control over each metric to compute and expose.
This is why custom metrics exist, and what the built-in metrics are exporting should be possible to be recreated in a specific custom metric writing some JavaScript code or in very specific and/or advanced cases via extensions. Just an example from the custom metric documentation. In any case, they both sound to me like solution proposals, but before it is relevant for us to understand the problems with the current implementation. What are the use cases you're trying to improve? |
At the moment, this is not planned, feel free to re-open or add more details. |
Feature Description
Hello,
http_req_duration
,grpc_req_duration
and something like these in third-party extensions for other protocols). Wouldn't be better to use generalized name likereq_duration
to describe main metric name?Suggested Solution (optional)
No response
Already existing or connected issues / PRs (optional)
No response
The text was updated successfully, but these errors were encountered: