Metric type refactor #2905
Closed
Metric type refactor #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
added
the
evaluation needed
Codecov Report
@@ Coverage Diff @@
## master #2905 +/- ##
==========================================
- Coverage 76.88% 76.86% -0.03%
==========================================
Files 225 223 -2
Lines 16867 16939 +72
==========================================
+ Hits 12969 13020 +51
- Misses 3066 3078 +12
- Partials 832 841 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
na--
reviewed
Feb 8, 2023
| type ObservedMetric struct { | ||
| *Metric | ||
| Sink Sink | ||
| Thresholds []Threshold |
na--
reviewed
Feb 8, 2023
| "max": sink.Max, | ||
| "avg": sink.Avg, | ||
| "med": sink.P(0.5), | ||
| "p(90)": sink.P(0.90), |
na--
reviewed
Feb 8, 2023
metrics/engine/ingester.go
Outdated
| // sequential integer ID, we would be able to use a slice for these buckets | ||
| // and eliminate the map loopkups altogether! | ||
|
|
||
| samplesByMetric := make(map[*metrics.Metric][]metrics.Sample) |
There was a problem hiding this comment.
This is inefficient, maybe we can avoid using output.SampleBuffer and do this in a custom AddMetricSamples()
codebien
commented
Feb 8, 2023
metrics/engine/engine.go
Outdated
Comment on lines
57
to
58
| metricsWithThresholds map[string]metrics.Thresholds | ||
| trackedMetrics map[string]*trackedMetric |
There was a problem hiding this comment.
We need to investigate as a better and long-term solution the metric.SequenceID option:
- We need to check if we can continue to keep in the long-term the sub-metrics as metrics.
codebien
force-pushed
the
refactor/tracked-metrics
branch
2 times, most recently
from
908a243 to
b25d18d
Compare
codebien
force-pushed
the
refactor/tracked-metrics
branch
from
b25d18d to
db36955
Compare
|
This is outdated now. Better to re-work it and re-open after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.