-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console output] http_req_failed : "succMark" & "failMark" seems inversed? #2306
Comments
Thanks for reporting this! Technically, since the So, I'm not sure if we should just reverse the marks, but maybe we should hide them or turn them into text labels? 🤔
Also, I am not sure if this should be a hack, a check just for the Lines 233 to 238 in 804203b
Or should it be a more universal solution? Maybe Rate metrics should have an additional parameter that allows users to specify that they are inverted? Similarly to how Trend metrics have a parameter that specifies if they are tracking time or not?
For now, as a workaround, you can define your own |
I got confused by this, too, while discovering k6.
To me, text labels would remove any ambiguity 👍 |
Hi, so just to clarify, is the %age shown the % of requests that failed? So 0% http_req_failed means 100% requests succeeded (either by the default comparison to 200 status code or overridden by the user)? So a checkmark in the output defines the amount of failed requests, and the x defines the amount of successful requests? |
Yes 😞 |
+1, that is overly confusing |
how is it going to affect thresholds? Should the http_req_failed: ['rate '] be reversed as well? |
@mariaduran-ecr, it shouldn't. The problem is that the end-of-test summary assumes that all And IIRC, |
I'm trying out k6 now and this definitely confused the heck out of me. |
Another proposal that I came up with in #3656 was to actually use words to say how many of the given rate were "truthy" This way it seems like there is no ambiguity. |
I am trying k6 and found this very confusing. Please reverse it. Thanks. |
Agreed, this is confusing. I add a check to set my own metric to make a little more sense, especially when presenting to higher-ups Code:
Output:
or
|
Brief summary
I think ✓ and ✗ are inversed here. There should be more failed than succeed.
k6 version
0.35.0
OS
Windows 10
Docker version and image (if applicable)
No response
Steps to reproduce the problem
Do a simple run of k6. Nothing fancy.
Expected behaviour
Actual behaviour
The text was updated successfully, but these errors were encountered: