Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging when API calls fail lead users to believe the experiment failed #775

Open
clayburn opened this issue Dec 18, 2024 · 0 comments
Open

Comments

@clayburn
Copy link
Member

At the end of the Build Validation Script executions, some API calls are made to populate the summary. These calls can fail for a few reasons (e.g. lack of API authorization, networking issues). If they do fail, the user is presented with some cryptic errors in eye-catching red text:

Response status code: 0
ERROR: Unable to connect to server to fetch build scan https://develocity.example.com/s/foo
Response status code: 0
ERROR: Unable to connect to server to fetch build scan https://develocity.example.com/s/bar

Often, the user will then click the build scan links and see that they do in fact exist.

In these cases, when a user is running the script manually, the experiment will still provide users with the quick links for investigation, so the experiment was not entirely a failure. The lack of summary should be treated more like a warning. It would be good to be more helpful and let the user know what happened, what the impact was, and how to remediate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant