Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

First sidebar appears over the top of the content area #660

Open
rooby opened this issue Mar 13, 2018 · 3 comments
Open

First sidebar appears over the top of the content area #660

rooby opened this issue Mar 13, 2018 · 3 comments

Comments

@rooby
Copy link

rooby commented Mar 13, 2018

Out of the box the govcms_zen theme prints the first sidebar over the top of the content area. It's very broken.

This was originally raised in #149 and that issue was closed however the issue was never actually fixed.
There was a pull request created at #254 but it seems that wasn't actually merged in.

That pull request also isn't really a fix, in that it doesn't fix the first sidebar, it just removes the first sidebar. So I'm not sure that is really a suitable workaround, but I guess it's better than having it there and broken. Maybe.

I'm not sure why the previous issue was just closed but this is definitely still a problem with 7.x-2.15. I'll check 7.x-2.16 but I suspect it will still be in there too.

@pandaskii
Copy link
Contributor

The first sidebar style and the region is not implemented in govcms_zen theme at all

https://github.com/govCMS/govCMS/blob/7.x-2.x/themes/govcms/govcms_zen/govcms_zen.info

It is a bug that the first sidebar being appeared in the theme info file

@rooby
Copy link
Author

rooby commented Mar 14, 2018

Ah, apologies for the confusion.

The issue is in the starterkit file: GOVCMS_STARTERKIT.info.txt

It contains the first sidebar, so when you fire up a new sub-theme it has the broken sidebar.

That's what the previous pull request removed, but that didn't get merged before the old issue was closed.

@tobybellwood
Copy link
Contributor

Could we not just create the necessary .region-sidebar-first css in govcms_zen?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants