New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't read fixed size of 1024 #3

Open

matthewrankin opened this issue Jun 28, 2017 · 1 comment

Contributor

matthewrankin commented Jun 28, 2017

In device.go the Read(p []byte) method uses a fixed length of 1024 to read the USBTMC bulk-in endpoint. Seems like I should refactor this.

The text was updated successfully, but these errors were encountered:

Contributor Author

matthewrankin commented Dec 27, 2019 •

edited

Loading

The magic number that needs to be eliminated is no longer 1024. It is now 512 in func (d *Device) readRemoveHeader(p []byte) (n int, err error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment