-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can ember-concurrency be removed? #81
Comments
Maybe we can just use async await? |
If we are actually using any async actions then we should not drop ember-concurrency. You can get yourself into a lot of trouble using async/await for actions and ember-concurrency is currently the most idiomatic way to do this in the Ember ecosystem 👍 |
@mansona What troubles? I use async actions all the time 😅 |
@Alonski common troublesome pattern without ember concurrency:
If the component is destroyed during |
That's a great example @jherdman 🎉 I've also had some issues with testing and timing that cause tests to be a bit intermittent. Most of these issues can be solved by just converting any async actions to Ember Concurrency tasks 👍 |
Ember.js is often called out on having a large filesize. I'm wondering if
ember-concurrency
can be removed in order to reduce thevendor.js
filesize.I understand that it's useful for dropping tasks to prevent multiple executes of a task when a task is already being performed. Perhaps there's an alternative to using a task that can be leveraged?
The text was updated successfully, but these errors were encountered: