-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create setup.py to enable pip packaging/installation #3
Comments
Among the things I think would be in a pip package are:
|
The protobuffer generated file fonts_public_pb2.py in this repo is redundantly kept at the FontBakery repo as well. |
I'd chmod a+x all the python scripts. I would also consider if they can be included as modules on other python code when needed or if they are only useful as standalone scripts. I have to look more carefully at that yet, though. |
In other words, packaging means we should come up with a good description of which tools the package provides, if they're meant for stand-alone usage on the command-line or as modules for other python programs, etc. Right now this repo is a bit messy which seems to be a side-effect of how it grew organically in the past as demands for new helper scripts showed up. Not much different from the current state of the FontBakery helper scripts, actually. |
I'll start by creating a setup.py for packaging the fontbakery helper/hotfix scripts that will be merged into this "tools" repo: fonttools/fontbakery#1639 After that, we'll add the scripts from this repo to that setup.py as well. I suggest that we push this python package to PyPI under the name |
Font Bakery from now on will be focused on a sigle purpose: a Quality-Assurance automated testing framework for font families. (issue googlefonts#3 and fonttools/fontbakery#1639)
Font Bakery from now on will be focused on a sigle purpose: a Quality-Assurance automated testing framework for font families. (issue googlefonts#3 and fonttools/fontbakery#1639)
avoid having to inport the whole of fontbakery as a dependency This is very minimal so I think it is acceptable. (issue googlefonts#3)
(the ones that came from fontbakery). And also updated dependencies on setup.py (issue googlefonts#3)
Font Bakery from now on will be focused on a sigle purpose: a Quality-Assurance automated testing framework for font families. (issue #3 and fonttools/fontbakery#1639)
avoid having to inport the whole of fontbakery as a dependency This is very minimal so I think it is acceptable. (issue #3)
(the ones that came from fontbakery). And also updated dependencies on setup.py (issue #3)
done. A first release built with this is available now for testing at https://pypi.python.org/pypi/gftools/0.1.0 |
Seems to install nicely:
|
A small thing, in the tag, you wrote the date as I request dates formatted YYYY-MM-DD with numbers so they always sort correctly :) |
oh! OK. I'll delete the current tag and create a new one. |
ok, done :-) |
let me know if the scripts work fine |
they did work fine for me here when I tested them. |
The scripts seem not to be in my path, eg
This should return the path, if it exists |
Seeing the other issue:
|
Would be good to have a setup.py script, so we could install this repo's tools via pip
The text was updated successfully, but these errors were encountered: