Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Step 9, LifecycleActivity #23

Open
csaba-csete-87 opened this issue Jun 5, 2018 · 1 comment
Open

Step 9, LifecycleActivity #23

csaba-csete-87 opened this issue Jun 5, 2018 · 1 comment

Comments

@csaba-csete-87
Copy link

Since the January 22, 2018 release of Architecture components, LifecycleActivity is deprecated.

The build.gradle file can be updated to:

implementation "android.arch.lifecycle:runtime:1.1.1"
implementation "android.arch.lifecycle:extensions:1.1.1"
annotationProcessor "android.arch.lifecycle:compiler:1.1.1"

and at point 4.) Open ui.detail.DetailActivity. Have DetailActivity extend LifecycleActivity instead of AppCompatActivity. we should just keep it AppCompatActivity

@egealpay
Copy link

egealpay commented Jul 26, 2018

I guess we should keep it as: public class DetailActivity extends AppCompatActivity implements LifecycleOwner

edit: As I saw, I was wrong. But not sure about what should we do so I am also looking for an answer for this question

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants