Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge: block release-please PR for "api: foo" until "api: foo" issue with "release blocking" is closed #5316

Open
noahdietz opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@noahdietz
Copy link
Contributor

It would be really cool if do not merge bot automatically added the do not merge label to the release-please PR labeled with api: foo when there is at least one open issue also labeled for api: foo that has the release blocking label. When all issues with release blocking for api: foo are resolved/the labels removed, do not merge bot would remove the do not merge label.

A real use case I'm dealing with is that I had to temporarily skip a test for a specific module, with the owner's permission, to get a massive PR merged, with the understanding that the owner would fix the tests and close the tracking issues before the next release. However, this is too easily forgotten/doesn't work in large teams, so using automation to warn other maintainers of open blockers would be really useful.

@noahdietz noahdietz added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 30, 2024
@parthea
Copy link
Contributor

parthea commented May 1, 2024

It could be helpful to have a prefix do-not-merge: for labels that are intended to be consumed by the do-not-merge bot https://github.com/googleapis/repo-automation-bots/tree/main/packages/do-not-merge

@noahdietz
Copy link
Contributor Author

Good idea Tony.

Another idea I had is if the repo is a monorepo with multiple releases, do not merge would want to look at the api: foo labels, but if it was a repo with only one release, then the api: foo labels wouldn't be necessary - for example, I would use this on the Go GAPIC generator, which of course is not an API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants