From fa9787096b8831df45da15228d3f9af4c54a5c0e Mon Sep 17 00:00:00 2001 From: Brent Shaffer Date: Fri, 27 Sep 2024 10:02:35 -0700 Subject: [PATCH] fix and rename tests again --- .github/workflows/backwards-compatibility-checks.yaml | 4 ++-- ...s-storage.yaml => conformance-tests-storage-emulator.yaml} | 0 ...ests-bigtable.yaml => system-tests-bigtable-emulator.yaml} | 4 ++-- ...ts-datastore.yaml => system-tests-datastore-emulator.yaml} | 4 ++-- ...ts-firestore.yaml => system-tests-firestore-emulator.yaml} | 4 ++-- ...em-tests-pubsub.yaml => system-tests-pubsub-emulator.yaml} | 4 ++-- ...-tests-spanner.yaml => system-tests-spanner-emulator.yaml} | 4 ++-- .github/workflows/{tests.yaml => unit-tests.yaml} | 0 Redis/tests/System/V1/CloudRedisClientTest.php | 3 ++- 9 files changed, 14 insertions(+), 13 deletions(-) rename .github/workflows/{emulator-conformance-tests-storage.yaml => conformance-tests-storage-emulator.yaml} (100%) rename .github/workflows/{emulator-system-tests-bigtable.yaml => system-tests-bigtable-emulator.yaml} (90%) rename .github/workflows/{emulator-system-tests-datastore.yaml => system-tests-datastore-emulator.yaml} (90%) rename .github/workflows/{emulator-system-tests-firestore.yaml => system-tests-firestore-emulator.yaml} (90%) rename .github/workflows/{emulator-system-tests-pubsub.yaml => system-tests-pubsub-emulator.yaml} (90%) rename .github/workflows/{emulator-system-tests-spanner.yaml => system-tests-spanner-emulator.yaml} (93%) rename .github/workflows/{tests.yaml => unit-tests.yaml} (100%) diff --git a/.github/workflows/backwards-compatibility-checks.yaml b/.github/workflows/backwards-compatibility-checks.yaml index 05e894738a92..64995944328e 100644 --- a/.github/workflows/backwards-compatibility-checks.yaml +++ b/.github/workflows/backwards-compatibility-checks.yaml @@ -1,4 +1,4 @@ -name: Backward Compatibility +name: Backwards Compatibility on: pull_request: types: [opened, synchronize, reopened, edited] @@ -121,4 +121,4 @@ jobs: echo "Add \"MAJOR_VERSION_ALLOWED=component1,component2\" to the PR description to allow " echo "major version releases for those components" exit 1 - fi \ No newline at end of file + fi diff --git a/.github/workflows/emulator-conformance-tests-storage.yaml b/.github/workflows/conformance-tests-storage-emulator.yaml similarity index 100% rename from .github/workflows/emulator-conformance-tests-storage.yaml rename to .github/workflows/conformance-tests-storage-emulator.yaml diff --git a/.github/workflows/emulator-system-tests-bigtable.yaml b/.github/workflows/system-tests-bigtable-emulator.yaml similarity index 90% rename from .github/workflows/emulator-system-tests-bigtable.yaml rename to .github/workflows/system-tests-bigtable-emulator.yaml index ed0e1d3ec85a..6cc00a8032cb 100644 --- a/.github/workflows/emulator-system-tests-bigtable.yaml +++ b/.github/workflows/system-tests-bigtable-emulator.yaml @@ -4,12 +4,12 @@ on: - main paths: - 'Bigtable/**' - - '.github/workflows/emulator-system-tests-bigtable.yaml' + - '.github/workflows/system-tests-bigtable-emulator.yaml' - '.github/emulator/**' pull_request: paths: - 'Bigtable/**' - - '.github/workflows/emulator-system-tests-bigtable.yaml' + - '.github/workflows/system-tests-bigtable-emulator.yaml' - '.github/emulator/**' name: Run Bigtable System Tests With Emulator permissions: diff --git a/.github/workflows/emulator-system-tests-datastore.yaml b/.github/workflows/system-tests-datastore-emulator.yaml similarity index 90% rename from .github/workflows/emulator-system-tests-datastore.yaml rename to .github/workflows/system-tests-datastore-emulator.yaml index 4fc1c6f23a48..722ebd2a9546 100644 --- a/.github/workflows/emulator-system-tests-datastore.yaml +++ b/.github/workflows/system-tests-datastore-emulator.yaml @@ -5,12 +5,12 @@ on: - main paths: - 'Datastore/**' - - '.github/workflows/emulator-system-tests-datastore.yaml' + - '.github/workflows/system-tests-datastore-emulator.yaml' - '.github/emulator/**' pull_request: paths: - 'Datastore/**' - - '.github/workflows/emulator-system-tests-datastore.yaml' + - '.github/workflows/system-tests-datastore-emulator.yaml' - '.github/emulator/**' permissions: contents: read diff --git a/.github/workflows/emulator-system-tests-firestore.yaml b/.github/workflows/system-tests-firestore-emulator.yaml similarity index 90% rename from .github/workflows/emulator-system-tests-firestore.yaml rename to .github/workflows/system-tests-firestore-emulator.yaml index 95305a657682..0a9c182c507e 100644 --- a/.github/workflows/emulator-system-tests-firestore.yaml +++ b/.github/workflows/system-tests-firestore-emulator.yaml @@ -4,12 +4,12 @@ on: - main paths: - 'Firestore/**' - - '.github/workflows/emulator-system-tests-firestore.yaml' + - '.github/workflows/system-tests-firestore-emulator.yaml' - '.github/emulator/**' pull_request: paths: - 'Firestore/**' - - '.github/workflows/emulator-system-tests-firestore.yaml' + - '.github/workflows/system-tests-firestore-emulator.yaml' - '.github/emulator/**' name: Run Firestore System Tests With Emulator permissions: diff --git a/.github/workflows/emulator-system-tests-pubsub.yaml b/.github/workflows/system-tests-pubsub-emulator.yaml similarity index 90% rename from .github/workflows/emulator-system-tests-pubsub.yaml rename to .github/workflows/system-tests-pubsub-emulator.yaml index 4485f267c6dc..df9feb0c5653 100644 --- a/.github/workflows/emulator-system-tests-pubsub.yaml +++ b/.github/workflows/system-tests-pubsub-emulator.yaml @@ -4,12 +4,12 @@ on: - main paths: - 'PubSub/**' - - '.github/workflows/emulator-system-tests-pubsub.yaml' + - '.github/workflows/system-tests-pubsub-emulator.yaml' - '.github/emulator/**' pull_request: paths: - 'PubSub/**' - - '.github/workflows/emulator-system-tests-pubsub.yaml' + - '.github/workflows/system-tests-pubsub-emulator.yaml' - '.github/emulator/**' name: Run PubSub System Tests With Emulator permissions: diff --git a/.github/workflows/emulator-system-tests-spanner.yaml b/.github/workflows/system-tests-spanner-emulator.yaml similarity index 93% rename from .github/workflows/emulator-system-tests-spanner.yaml rename to .github/workflows/system-tests-spanner-emulator.yaml index d233c97dff66..335f31acd64d 100644 --- a/.github/workflows/emulator-system-tests-spanner.yaml +++ b/.github/workflows/system-tests-spanner-emulator.yaml @@ -4,11 +4,11 @@ on: - main paths: - 'Spanner/**' - - '.github/workflows/emulator-system-tests-spanner.yaml' + - '.github/workflows/system-tests-spanner-emulator.yaml' pull_request: paths: - 'Spanner/**' - - '.github/workflows/emulator-system-tests-spanner.yaml' + - '.github/workflows/system-tests-spanner-emulator.yaml' name: Run Spanner System Tests With Emulator permissions: contents: read diff --git a/.github/workflows/tests.yaml b/.github/workflows/unit-tests.yaml similarity index 100% rename from .github/workflows/tests.yaml rename to .github/workflows/unit-tests.yaml diff --git a/Redis/tests/System/V1/CloudRedisClientTest.php b/Redis/tests/System/V1/CloudRedisClientTest.php index cdffda3003ec..89ee50234c9a 100644 --- a/Redis/tests/System/V1/CloudRedisClientTest.php +++ b/Redis/tests/System/V1/CloudRedisClientTest.php @@ -105,9 +105,10 @@ public function testDeleteOperation() $this->assertTrue($deleteOp->operationSucceeded()); // Ensure delete op succeeded + $instances = self::$client->listInstances(ListInstancesRequest::build(self::$parent)); $this->assertSame(0, count(array_map( fn ($instance) => $instance->getName() === $instanceName, - iterator_to_array($client->listInstances($listInstancesRequest)->iterateAllElements()) + iterator_to_array($instances->iterateAllElements()) ))); } }