Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running go install ./... in step 7 of "Development Environment" returns compile errors #1539

Closed
julieqiu opened this issue Sep 23, 2024 · 1 comment
Closed

Running go install ./... in step 7 of "Development Environment" returns compile errors #1539

julieqiu opened this issue Sep 23, 2024 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@julieqiu
Copy link
Member

julieqiu commented Sep 23, 2024 •
edited
Loading

I followed these steps: https://github.com/googleapis/gapic-showcase?tab=readme-ov-file#development-environment

At step 7 when I ran go install ./...

To compile the Showcase binary, as well as associated development utilities in this repository, run the following after you make changes:

go install ./...

I got these errors:

 go install ./...                                         

# github.com/googleapis/gapic-showcase/cmd/gapic-showcase
cmd/gapic-showcase/gapic-showcase.go:52:11: msg.String undefined (type protoreflect.ProtoMessage has no field or method String)
cmd/gapic-showcase/gapic-showcase.go:55:26: cannot use msg (variable of type protoreflect.ProtoMessage) as protoiface.MessageV1 value in argument to marshaler.Marshal: protoreflect.ProtoMessage does not implement protoiface.MessageV1 (missing method ProtoMessage)

It looks like the code in cmd/gapic-showcase/gapic-showcase.go is autogenerated.
@julieqiu julieqiu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 23, 2024
@codyoss
Copy link
Member

codyoss commented Dec 3, 2024

This was fixed by reverting #1534. Also added go build to CI so this does not happen again.

@codyoss codyoss closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julieqiu @codyoss