Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-gen snippets exceeds Python recursion limit in some cases #2297

Open
vchudnov-g opened this issue Dec 16, 2024 · 1 comment
Open

auto-gen snippets exceeds Python recursion limit in some cases #2297

vchudnov-g opened this issue Dec 16, 2024 · 1 comment
Assignees
@vchudnov-g
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vchudnov-g
Copy link
Contributor

Generating the GAPIC for compute alpha (using the disco-to-proto3 converter to create proto3s from the Discovery file) results in a RecursionError: maximum recursion depth exceeded while calling a Python object.

I even tried increasing the limit by inserting a sys.setrecursionlimit(3000) at the top of generator.py and it didn't work. This seems to be a bug in the auto-gen snippet code. Adding an item "autogen-snippets=False" to the opt_args field of the py_gapic_library BUILD rule bypasses this problem.

It's not clear what triggers this bug, but it could show up for other APIs.
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 16, 2024
@parthea parthea added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 16, 2024
@parthea
Copy link
Contributor

parthea commented Dec 16, 2024

Switching to P2 based on the latest comment in b/380466345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vchudnov-g vchudnov-g

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g