Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch's document link is wrong #841

Closed
ClanceyLu opened this issue Jun 11, 2024 · 4 comments
Closed

fetch's document link is wrong #841

ClanceyLu opened this issue Jun 11, 2024 · 4 comments

Comments

@ClanceyLu
Copy link

8.0 uses node-fetch-native,but the document write it uses node-fetch.
They do not implement proxy functions in the same way.
When I upgraded to 8.0, it can't work.

@antonmedv
Copy link
Collaborator

@antongolub

@antongolub
Copy link
Collaborator

Hmm, unjs/node-fetch-native#125 maybe?
Anyway, we need a reproducible example to start digging.

@ClanceyLu
Copy link
Author

Hmm, unjs/node-fetch-native#125 maybe? Anyway, we need a reproducible example to start digging.

Thanks!
I have already resolved this issue, just wanted to point out that there is an error in the documentation here.
https://google.github.io/zx/api#fetch

I thought it was still using node-fetch, but after checking the code, I realized it has been switched to node-fetch-native.

@antongolub
Copy link
Collaborator

antongolub commented Jun 11, 2024

Oh. Just a typo in docs))) I'll fix the link.

antongolub added a commit to antongolub/zx that referenced this issue Jun 15, 2024
antonmedv pushed a commit that referenced this issue Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants