Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore alternatives to mount for Docker compatibility in importers #64

Open
jkppr opened this issue Mar 8, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@jkppr
Copy link
Collaborator

jkppr commented Mar 8, 2024

Currently, some hashr importers rely on directly mounting ISO files within Docker containers (e.g. windows or iso importer). This approach is not generally supported by Docker due to security restrictions. Explore and implement alternatives to eliminate the need for the --privileged flag. (see #61)

Considerations:

  • Tools: Investigate libraries or tools like 7z, xorriso, or others that can extract or access contents of ISO files without requiring a direct mount.
  • Performance Impact: Evaluate any trade-offs in terms of performance or resource usage between the mounting approach and potential alternatives.
  • Importer Scope: Identify the specific importers within hashr that rely on mount and will need to be refactored.
@jkppr jkppr added the enhancement New feature or request label Mar 8, 2024
@manojks1999
Copy link

@jkppr ,
We can add a multi-stage build to extract and mount the content.

@jkppr
Copy link
Collaborator Author

jkppr commented Aug 7, 2024

@manojks1999 Thanks for the input! Could you elaborate on how your idea would help solve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants