Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle DownloadProgressDialogFragment visibility if visible #2821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anandwana001
Copy link
Collaborator

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.36%. Comparing base (be3bd7b) to head (0093757).

Files with missing lines Patch % Lines
...flineareas/selector/OfflineAreaSelectorFragment.kt 57.14% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2821      +/-   ##
============================================
- Coverage     61.37%   61.36%   -0.02%     
- Complexity     1169     1170       +1     
============================================
  Files           266      266              
  Lines          6304     6307       +3     
  Branches        899      901       +2     
============================================
+ Hits           3869     3870       +1     
  Misses         1907     1907              
- Partials        528      530       +2     
Files with missing lines Coverage Δ
...flineareas/selector/OfflineAreaSelectorFragment.kt 56.52% <57.14%> (-3.48%) ⬇️

@gino-m
Copy link
Collaborator

gino-m commented Nov 13, 2024

@shobhitagarwal1612 to review

@gino-m gino-m removed the request for review from scolsen November 13, 2024 13:50
@gino-m
Copy link
Collaborator

gino-m commented Nov 13, 2024

As per @shobhitagarwal1612, this is a workaround, but doesn't address the root cause.

@anandwana001 Can you please describe how to repro and file a bug to migrate the dialog to Compose? This way we avoid managing the Fragment altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fragment already added: DownloadProgressDialogFragment
4 participants