Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Health] Map features and card flicker on remote changes #2819

Open
gino-m opened this issue Nov 11, 2024 · 0 comments
Open

[Code Health] Map features and card flicker on remote changes #2819

gino-m opened this issue Nov 11, 2024 · 0 comments
Labels
type: bug Something isn't working type: code health Improvements to readability or robustness of codebase

Comments

@gino-m
Copy link
Collaborator

gino-m commented Nov 11, 2024 •
edited
Loading

Also:

Initial debugging reveals that GoogleMapsFragment.setFeatures() is called 5 times when an LOI is modified in the remote datastore:

2024-11-11 16:17:54.337  3951-3951  GoogleMapsFragment      com.google.android.ground            V  setFeatures() called with 5 features
2024-11-11 16:17:54.712  3951-3951  GoogleMapsFragment      com.google.android.ground            V  setFeatures() called with 5 features
2024-11-11 16:17:54.720  3951-3951  GoogleMapsFragment      com.google.android.ground            V  setFeatures() called with 5 features
2024-11-11 16:17:54.726  3951-3951  GoogleMapsFragment      com.google.android.ground            V  setFeatures() called with 6 features
2024-11-11 16:17:54.732  3951-3951  GoogleMapsFragment      com.google.android.ground            V  setFeatures() called with 6 features

While SurveyRepository.loadAndSyncSurveyWithRemote is called only once as expected. We may need to debounce or otherwise isolate changes to the local db to prevent the UI from getting thrashed.

Originally posted by @gino-m in #2728
@gino-m gino-m added the type: code health Improvements to readability or robustness of codebase label Nov 11, 2024
@gino-m gino-m changed the title [Code Health] Map updated multiple times on remote change [Code Health] Map flickers on remote changes Nov 11, 2024
@gino-m gino-m changed the title [Code Health] Map flickers on remote changes [Code Health] Map features and cards flicker on remote changes Nov 11, 2024
@gino-m gino-m added the type: bug Something isn't working label Nov 11, 2024
@gino-m gino-m changed the title [Code Health] Map features and cards flicker on remote changes [Code Health] Map features and cards flicke on remote changes Nov 11, 2024
@gino-m gino-m changed the title [Code Health] Map features and cards flicke on remote changes [Code Health] Map features and card flicker on remote changes Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working type: code health Improvements to readability or robustness of codebase
Projects
Ground
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gino-m