Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Survey list] Show hamburger menu on survey list #2660

Open
4 tasks
gino-m opened this issue Aug 16, 2024 · 13 comments
Open
4 tasks

[Survey list] Show hamburger menu on survey list #2660

gino-m opened this issue Aug 16, 2024 · 13 comments
Labels
for pm/ux review Product decision needed type: fr Request for new feature
Milestone

Comments

@gino-m
Copy link
Collaborator

gino-m commented Aug 16, 2024

After first sign in the "<-" button has no effect. The proposed solution is:

  • Replace the back/up button with the hamburger menu
  • Handle "no survey" state after first signing in
    • Show "Choose survey" and heading text shown below
    • Disable "Data sync status" menu option

Image

@gino-m gino-m added the type: bug Something isn't working label Aug 16, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Aug 16, 2024

Or should we just implement the new design? In that case, what does the hamburger icon do right after sign-in?

** obsolete image deleted **

@gino-m gino-m added this to the GA release milestone Aug 19, 2024
@rawbzz
Copy link

rawbzz commented Aug 19, 2024

Shouldn't the hamburger menu open up the side panel?

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 19, 2024

Shouldn't the hamburger menu open up the side panel?

That would make sense, a few follow-up questions:

  • In that case the user avatar would be shown both in the survey list and side panel. Should we remove it from the survey list then?
  • What do we show in the side panel when no survey has been selected yet?

@rawbzz
Copy link

rawbzz commented Aug 19, 2024

I feel like it'd be okay to remove from the survey list, esp if the main place a profile will live is in the side panel?

and also for no survey selected, I think we can do 2 things. One either prompt a user to choose a survey or hide that section completely?

Screenshot 2024-08-19 at 4 13 15 PM

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 20, 2024

I think the last option makes sense, as it makes it clear that no survey is selected. Offline map imagery isn't per-survey, so it can stay active, but "Data sync status" (ex "History and sync status") should be disabled

@rawbzz
Copy link

rawbzz commented Aug 21, 2024

ok! disabled the data sync status

Screenshot 2024-08-21 at 12 48 37 PM

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 21, 2024

LGTM!

@gino-m gino-m added the type: fr Request for new feature label Aug 22, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Aug 22, 2024

@amegantz for UXW - "you current have no survey.." sounds redundant.

@amegantz
Copy link

How about this?
image
No survey selected yet
[Select a survey]

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 28, 2024

@amegantz Do we need the work "yet"? If feels a little extra, no?

@amegantz
Copy link

YOU feel a little extra.

Just kidding, we can do without the "yet." It's a casual tone thing I added since we had the space

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 29, 2024

Haha, ok, sgtm!

@gino-m gino-m changed the title [Survey list] User unable to sign out if no surveys are accessible [Survey list] Show hamburger menu on survey list Nov 13, 2024
@gino-m gino-m removed the type: bug Something isn't working label Nov 13, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Nov 13, 2024

There's already a fixed issue to disable the up button #2692, so recasting this as a feature request.

@gino-m gino-m added the for pm/ux review Product decision needed label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for pm/ux review Product decision needed type: fr Request for new feature
Projects
Status: No status
Development

No branches or pull requests

4 participants