-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Swift Package Manager #258
Comments
If someone wants to contribute support, we'd be happy to review it. The hard part is going to be we don't want to reshuffle the code layout since it would break anyone directly integrating sources for the things they need. Likewise, we wouldn't want each directory to become a giant library, it probably needs to be like the cocoapods support where there are small units so folks can only depend on the parts they need. |
@thomasvl Is it ok to migrate this project to ARC? |
That's likely a breaking change for folks directly using sources in their projects. And every class would need to be double checked to see if things would be impacted by moving to ARC. ARC being pedantic can actually make some code slower because of the extra memory management it inserts. |
What about conditionally enabling ARC with compiler flags and macros?, would be tricky though. |
I'm surprised Swift Package Manager isn't being seriously considered for this repo yet. Is the worry of a breaking change the only thing holding it back? |
From what we've seen on other ObjC projects, we'd probably should do a layout change because of how SwiftPM exposes things (like Firebase, gtm-session-fetcher, etc. have done). So yes, all that is what's holding things back. From some things I've seen, it seems like CocoaPods is generally used for more integrations, SwiftPM usage is on the rise (but still a ways behind). We're doing some general cleanup/pruning in here now, it might be worth revisiting ARC & SwiftPM after that work completes. |
Great to hear it's in the pipeline! For example a quick search of "swift package manager" shows many issues opened on projects: ^ that's not even ordered by date, but all opened within the last 3 weeks. iOS devs everywhere are ready to exclusively use swift package manager and drop CocoaPods. The iOS community was impatiently waiting for swiftpm support from firebase a couple of years ago. It's still the second-most commented on issue: |
Hi, I'd also like to emphasise the point of @maxxfrazer |
News? |
News after 84 years? Goole, WAKE UP, please!!!! |
Is there plans to add Swift Package Manager to this project?
The text was updated successfully, but these errors were encountered: