Bad Assumption in AcceptableMimeType, Leading to "Invalid MIME type"

[speedplane]

The function AcceptableMimeType in base/py/util.py incorrectly assumes that all mimetypes will have a forward slash within them:

def AcceptableMimeType(accept_patterns, mime_type):
    """Return True iff mime_type is acceptable for one of accept_patterns.

    Note that this function assumes that all patterns in accept_patterns
    will be simple types of the form "type/subtype", where one or both
    of these can be "*". We do not support parameters (i.e. "; q=") in
    patterns.

    Args:
      accept_patterns: list of acceptable MIME types.
      mime_type: the mime type we would like to match.

    Returns:
      Whether or not mime_type matches (at least) one of these patterns.
    """
    if '/' not in mime_type:
        raise exceptions.InvalidUserInputError(
            'Invalid MIME type: "%s"' % mime_type)

This assumption fails for .p12 files, which are used for server-to-server authentication. The function mimetypes.guess_type returns x-pkcs12 for .p12 files instead of application/x-pkcs12. This may be a bug with mimetypes, but it should nevertheless be handled properly by the apitools.

[craigcitro]

Ah, yes, that's entirely believable. Would you be willing to send along a PR with the fix?

[speedplane]

I'd like to, but I'm just using this function to get Google's Managed VM system to work and this is only one of several other issues I'm facing. I have a workaround for this (e.g., not upload any .p12 files), so I'm not sure I'll be able to get to it.

[craigcitro]

So I just took a quick skim through the stdlib -- it looks like mimetypes should return the expected application/x-pkcs12 here.

Do you have a small failing sample?

[elharo]

Ping. This just caused gcloud to crash: https://stackoverflow.com/questions/49652346/deploying-app-engine-app-with-p12-file-using-cloud-tools-for-eclipse

Any progress here?