-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Allow cycles between nodes #65
Comments
Hi @el-agua, can you help us out and perhaps share model(s) or code to reproduce those models which display both behaviors? Thanks. |
Hi @el-agua, we're trying to figure out what exactly is the use case for this in order for us to prioritize it correctly. Can you maybe describe your exact use case and the type of model you are using and its use? |
I have found model explorer, using the custom adapter api, to be incredibly useful for modeling large control systems. As with most feedback control, cycles are inevitable. It seems that with the workaround, the frontend can already support such a display. However, direct support would greatly simplify this. Even something along the lines of visualizing RNN/SSM blocks would benefit from this? |
Hi @el-agua, since your use case is not specific for ML models, we don't quite have the bandwidth to prioritize this use case. That being said, once the front-end becomes open source we are certainly welcoming contributions to add this. Thanks for your understanding. |
Often times, it may be useful for cycles to be displayed in the graph between individual nodes. Right now, this is impossible.
Example of a control feedback loop
Currently, if I tried to construct this graph with individual nodes. You get the following:
However, if I create an "in" and "out" node, representing each of these functions as layers, I get the desired behavior.
However, this can be quite tedious. Might be useful as a toggle in the settings?
The text was updated successfully, but these errors were encountered: