Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large challenging graph to display #50

Open
justinchuby opened this issue May 18, 2024 · 1 comment
Open

Large challenging graph to display #50

justinchuby opened this issue May 18, 2024 · 1 comment
Assignees
Labels
front-end For issues where the root is mostly occurring on the front-end priority 2 This issue is recognized and will likely not be completed until after the next release stat:awaiting model-navigator The issue is actively being worked on by our navigators type:performance Performance Issue

Comments

@justinchuby
Copy link
Contributor

justinchuby commented May 18, 2024

The UI keeps displaying "Processing please wait" when trying to expand the graph. The graph has ~32k nodes.

image

Steps

pip install model_explorer_onnx==0.1.4
model-explorer model_1.onnx --extensions=model_explorer_onnx

Model: https://drive.google.com/file/d/1R3vW92eSLbtolH53HBlhG2CdEQPs_PO6/view obtained from microsoft/onnxruntime#20354

@justinchuby justinchuby changed the title Large challenging graph Large challenging graph to display May 18, 2024
@jinjingforever
Copy link
Collaborator

Thank you for trying this out!

Your observation is correct. For super large graphs like the one you linked, the "processing please wait" message will often appear when you expand or collapse a layer because Model Explorer needs to layout all the layers affected by it, especially when there are multiple expanded layers.

We will explore some more ways to make this process faster. (And thanks for providing a great model for us to test!)

@jinjingforever jinjingforever self-assigned this May 20, 2024
@pkgoogle pkgoogle added the type:performance Performance Issue label May 20, 2024
@pkgoogle pkgoogle self-assigned this Jun 3, 2024
@pkgoogle pkgoogle added priority 2 This issue is recognized and will likely not be completed until after the next release stat:awaiting model-navigator The issue is actively being worked on by our navigators front-end For issues where the root is mostly occurring on the front-end labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end For issues where the root is mostly occurring on the front-end priority 2 This issue is recognized and will likely not be completed until after the next release stat:awaiting model-navigator The issue is actively being worked on by our navigators type:performance Performance Issue
Projects
None yet
Development

No branches or pull requests

3 participants