Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagas? #17

Open
awhillas opened this issue Oct 13, 2016 · 2 comments
Open

Sagas? #17

awhillas opened this issue Oct 13, 2016 · 2 comments

Comments

@awhillas
Copy link

Hey,
I just went though the whole saga of the sagas setup. Perhaps you might want to make sagas or thunk optional extras?

Also, most people are going to need "babel-polyfill" in which case i went the babel-runtime route as it seemed the lest invasive in future development efforts.

Also, hit a weird bug with the dev tools that you seemed to have solved, which i was surprised to not see here?

@goldhand
Copy link
Owner

Thanks for these suggestions @awhillas
Hopefully adding sagas wasn't too difficult (did you add them here?)
I haven't used them before (I've been using thunk) but they look great, I love async/await! If you have your saga setup in the configureStore.js file it shouldn't be too hard to make it a cookiecutter option, I would accept a pull request for that.

Will create a separate issue for babel-polyfill. Currently Promise and fetch have polyfills for them but they are not the babel-polyfill. Would be a lot better to just have babel-polyfill rather than the promise and fetch ProvidePlugin configuration

Regarding the devtools setup, I'll push that fix asap haha...

goldhand added a commit that referenced this issue Oct 13, 2016
@awhillas
Copy link
Author

Oh,

A use case for the sagas would be to do a Django login/logout button in the demo app. Its a pain in the butt to do from scratch and would really attract some interest, as well as be a good use case example for React+Django+Sagas(+saga testing), but then might need something like a dependancy on Django REST framework.

Maybe that should be a fork off this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants