x/tools/gopls: show underlying type on hover over alias

[jacobzim-stl]

gopls version

golang.org/x/tools/gopls v0.17.1

go env

n/a

What did you do?

Note: this is a feature request

Given

// This is a dog.
type Dog struct {
    Name string `json:"name"`
    Age int `json:"age"`
}

type Hound = Dog

// A Puppy is a Dog with an age less than 2.
type Puppy = Dog

I hovered over Hound and Puppy

What did you see happen?

The hover message reads

type Hound = Dog

and respectively

type Puppy = Dog

A puppy is a dog with an age less than 2.

What did you expect to see?

type Hound = Dog

This is a dog.

type Dog struct {
    Name string `json:"name"`
    Age int `json:"age"`
}

and respectively

type Puppy = Dog

A puppy is a dog with an age less than 2.

type Dog struct {
    Name string `json:"name"`
    Age int `json:"age"`
}

I like the semantic that docstrings are inherited if, and only if, the alias provides no docstring of its own.

Editor and settings

n/a

Logs

n/a

[findleyr]

This sounds like a nice improvement. Thanks.