Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for preheat APIs #445

Open
kakkoyun opened this issue Jun 5, 2024 · 2 comments
Open

Add support for preheat APIs #445

kakkoyun opened this issue Jun 5, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kakkoyun
Copy link

kakkoyun commented Jun 5, 2024

Feature Request: Support for Harbor Preheat API Configuration

Is your feature request related to a problem? Please describe.

Currently, this provider does not support configuring the Harbor Preheat API. This feature would greatly enhance the ability to manage image preheating in Harbor projects, ensuring optimized performance and efficiency.

For more details, refer to the official Harbor documentation on preheating images: Harbor Preheat Images Documentation.

Describe the solution you'd like

I am keen to contribute by adding the necessary APIs for this feature. However, I would appreciate some guidance on how to move forward. Could you provide any pointers or resources to help me get started?

@flbla flbla self-assigned this Jun 5, 2024
@flbla flbla added the enhancement New feature or request label Jun 5, 2024
flbla added a commit that referenced this issue Jun 7, 2024
@flbla
Copy link
Contributor

flbla commented Jun 7, 2024

hi @kakkoyun,
thank you for the feature request.
we also need to manage preheat instances before we can create policies.

I started to implement the preheat instance

resource "harbor_preheat_instance" "example" {
  name       = "example-preheat-instance"
  vendor     = "dragonfly"
  endpoint   = "http://example.com"
  auth_mode  = "BASIC"
  username   = "example-user"
  password   = "example-password"
}

let me know if you want to implement preheat policy

flbla added a commit that referenced this issue Jun 7, 2024
flbla added a commit that referenced this issue Jun 7, 2024
flbla added a commit that referenced this issue Jun 7, 2024
flbla added a commit that referenced this issue Jun 7, 2024
flbla added a commit that referenced this issue Jun 7, 2024
Signed-off-by: flbla <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kakkoyun
Copy link
Author

@flbla Thanks for the swift action! Awesome, I'll try this sometime this week and give you my feedback 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants