Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootUrl not used? #25

Open
abretaud opened this issue Jun 1, 2023 · 4 comments
Open

rootUrl not used? #25

abretaud opened this issue Jun 1, 2023 · 4 comments

Comments

@abretaud
Copy link
Member

abretaud commented Jun 1, 2023

Not sure, but looking at the code, I see no usage of --root-url when running genoboo run

@abretaud
Copy link
Member Author

abretaud commented Jun 1, 2023

Nevermind, it's used somehow, for css/images

Could we get rid of that? not super predictale for gxit

@mboudet
Copy link
Member

mboudet commented Jun 6, 2023

(Is that like, brexit for galaxy?)

Not sure if we can get rid of it, seems like it's use by several core modules

@abretaud
Copy link
Member Author

abretaud commented Jun 6, 2023

(Is that like, brexit for galaxy?)
genius§

I didn't find it in the code, I probably didn't search for the good string... humpff
I didn't use it for gxit => images are not displayed, not sure if anything else's impacted. but it's usable.

@mboudet
Copy link
Member

mboudet commented Jun 6, 2023

It's a default 'meteor' variable : https://docs.meteor.com/environment-variables.html#ROOT-URL
We don't use it, but several internal modules do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants