Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prometheus #99

Open
Felixoid opened this issue Oct 14, 2020 · 7 comments
Open

Upgrade prometheus #99

Felixoid opened this issue Oct 14, 2020 · 7 comments

Comments

@Felixoid
Copy link
Collaborator

Here's a branch with the updated vendor path https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus

@Felixoid Felixoid added this to the Release 0.13 milestone Oct 14, 2020
@ihard
Copy link

ihard commented Mar 18, 2021

Hi, how working is the branch? I would like to update since there is an assumption that some promql queries do not work because of this.

@Felixoid
Copy link
Collaborator Author

Hey. I have zero experience in Prom, so can't provide any support on the topic. I am not sure why has removed help wanted, since help is definitely needed here

@Felixoid
Copy link
Collaborator Author

I upgraded the branch https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus and there some initial attempts to adjust the code to the latest prom. But since I am not in the context of Prometheus, I am not sure what should be next.

As far as I see, the current prometheus.Querier must be split into two different types, Querier and ChunkQuerier. If one would take care of it, I'll for sure spend time to review it

@bzed
Copy link
Contributor

bzed commented May 25, 2021

As you can connect a normal prometheus as remote reader - I'm wondering if its needed to have a prometheus integrated. Providing the remote storage endpoint and running a prometheus instance should be enough? or am I missing something?

@Felixoid
Copy link
Collaborator Author

GCH has a feature to provide graphite metrics in the native prometheus format. See https://github.com/lomik/graphite-clickhouse/blob/master/prometheus/querier_select.go#L33, for example

@bzed
Copy link
Contributor

bzed commented May 25, 2021

Ah sorry, I've missed that / is being routed into prometheus. I thought that the remote read/write interface was different code.

@bzed
Copy link
Contributor

bzed commented Aug 16, 2023

@lomik you've updated prometheus with 5955725, any plans to implement the ChunkQuerier also? Otherwise a collegue will have a look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants