-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade prometheus #99
Comments
Hi, how working is the branch? I would like to update since there is an assumption that some promql queries do not work because of this. |
Hey. I have zero experience in Prom, so can't provide any support on the topic. I am not sure why has removed |
I upgraded the branch https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus and there some initial attempts to adjust the code to the latest prom. But since I am not in the context of Prometheus, I am not sure what should be next. As far as I see, the current prometheus.Querier must be split into two different types, Querier and ChunkQuerier. If one would take care of it, I'll for sure spend time to review it |
As you can connect a normal prometheus as remote reader - I'm wondering if its needed to have a prometheus integrated. Providing the remote storage endpoint and running a prometheus instance should be enough? or am I missing something? |
GCH has a feature to provide graphite metrics in the native prometheus format. See https://github.com/lomik/graphite-clickhouse/blob/master/prometheus/querier_select.go#L33, for example |
Ah sorry, I've missed that / is being routed into prometheus. I thought that the remote read/write interface was different code. |
Here's a branch with the updated vendor path https://github.com/lomik/graphite-clickhouse/tree/upgrade_prometheus
The text was updated successfully, but these errors were encountered: