Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glslify.bundle is not a function #13

Open
ekatzenstein opened this issue Oct 14, 2016 · 4 comments
Open

glslify.bundle is not a function #13

ekatzenstein opened this issue Oct 14, 2016 · 4 comments

Comments

@ekatzenstein
Copy link

The loader works with earlier version of glslify, but glslify.bundle is no longer a method for the glslify package. Do you have suggestions for a work-around?

@pqml
Copy link
Collaborator

pqml commented May 12, 2017

My pull-request should fix this.
I've tested it on Webpack 2 and it seems to work fine

@wdanilo
Copy link

wdanilo commented Dec 28, 2017

bump.
When will it be merged into master? Its 9 months old ...

@rreusser
Copy link
Member

rreusser commented Dec 28, 2017

@wdanilo The best way to get it merged is to use the PR branch and report back with how it goes. PRs with lots of 👍 's and "Please merges" span the gamut from flawless to completely unusable, and without devoting an afternoon to it, it can be pretty difficult to tell the difference. I made a couple superficial comments on the PR, but adding any feedback you might have is the best way to move it forward. Thanks!

@Apidcloud
Copy link
Collaborator

Hello, @ekatzenstein. Sorry for the delay.

Could you try #15 and let us know if it works for you?

We are trying to merge it soon, and it would be great to have some more feedback on current use cases.

Thanks 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants