-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.6.0 beta - Flow and JSX support #107
Comments
Sweet :) |
Congrats! I worked on a major refactoring to split it up into smaller parts that make code more readable and easier to tweak, adjust, unit test etc. I've also added support for a better way to use replace and search as APIs, with support for filter actions to f.ex append/prepend specific nodes, not just Raw. Was very difficult for me to use existing docs and understand how to use custom replace functions. Please improv docs and tests, esp. covering examples for classes and ES6 stuff, flow, jsx etc. Cheers! |
I have one more commit, which I haven't include in any PR gratex@54d889a654f7b9318d7279ba6 It was just a quick workaround, not widly tested. Take a look at if if you want and I may create PR if you think it's suitable.... |
Christian: yeah docs are in very "strange" style. See grasp-samples and grasp-tools repo. It took me while do decode gkz thinking. |
Can you expand on how they are "strange", what could be done to improve them? |
For one add better, more real life examples. I couldn't figure out how to use the replace callback function. Also, no examples for methods in classes etc. Examples are only for very simple cases like adding two numbers and such. |
Hey guys,
Check out and test support for Flow type annotations and JSX by installing the beta with
npm install grasp@beta
Still to do:
The text was updated successfully, but these errors were encountered: