Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.0 beta - Flow and JSX support #107

Open
2 tasks
gkz opened this issue Dec 6, 2016 · 7 comments
Open
2 tasks

0.6.0 beta - Flow and JSX support #107

gkz opened this issue Dec 6, 2016 · 7 comments

Comments

@gkz
Copy link
Owner

gkz commented Dec 6, 2016

Hey guys,
Check out and test support for Flow type annotations and JSX by installing the beta with npm install grasp@beta

Still to do:

  • Update syntax defs with full Flow syntax
  • Update equery parser to be able to use Flow/JSX
@gkz gkz added the discussion label Dec 6, 2016
@kristianmandrup
Copy link

Sweet :)

@gkz
Copy link
Owner Author

gkz commented Dec 14, 2016

@ainthek @adros let me know if I'm missing anything that you have in your fork

@kristianmandrup
Copy link

Congrats!

I worked on a major refactoring to split it up into smaller parts that make code more readable and easier to tweak, adjust, unit test etc. I've also added support for a better way to use replace and search as APIs, with support for filter actions to f.ex append/prepend specific nodes, not just Raw.

Was very difficult for me to use existing docs and understand how to use custom replace functions. Please improv docs and tests, esp. covering examples for classes and ES6 stuff, flow, jsx etc.

Cheers!

@adros
Copy link
Contributor

adros commented Dec 15, 2016

I have one more commit, which I haven't include in any PR

gratex@54d889a654f7b9318d7279ba6

It was just a quick workaround, not widly tested. Take a look at if if you want and I may create PR if you think it's suitable....

@ainthek
Copy link

ainthek commented Dec 20, 2016

Christian: yeah docs are in very "strange" style. See grasp-samples and grasp-tools repo. It took me while do decode gkz thinking.

@gkz
Copy link
Owner Author

gkz commented Dec 20, 2016

Can you expand on how they are "strange", what could be done to improve them?

@kristianmandrup
Copy link

For one add better, more real life examples. I couldn't figure out how to use the replace callback function. Also, no examples for methods in classes etc. Examples are only for very simple cases like adding two numbers and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants