Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow to limit results by path length in UI #3660

Closed
p- opened this issue Jul 10, 2024 · 1 comment
Closed

Feature request: allow to limit results by path length in UI #3660

p- opened this issue Jul 10, 2024 · 1 comment
Labels
enhancement New feature or request VSCode

Comments

@p-
Copy link
Contributor

p- commented Jul 10, 2024

Is your feature request related to a problem? Please describe.

When using MRVA with a query (custom or default) that yields a lot of results it is often hard to figure out which of the results are the most promising ones. See also: Feature request: Display length of shortest path in UI.
Currently there's no (simple) feature in CodeQL to limit query results by max path lengths, so this has to be done in the result viewer or by filtering the Sarif files.
It would be nice to filter out all results that have paths that are longer than a certain number. This number should be freely selectable as sensible values depend on the query and the language (e.g. Java is known as a more verbose language and has often longer code paths).

Describe the solution you'd like

It would be nice if there was a filter option (e.g. called "max path length") to filter out results with a path length that is over a certain value (For MRVA and maybe also for local queries).

I've hacked this together in my experimental branch and it's already useful - see commit p-@7f6f9c9

Image

Additional context

See also: Feature request: Display length of shortest path in UI

@p- p- added the enhancement New feature or request label Jul 10, 2024
@jf205 jf205 self-assigned this Jul 22, 2024
@jf205
Copy link
Contributor

jf205 commented Jul 22, 2024

Hi @p-! Thanks for creating this issue, we appreciate the thought you've put into it. I think we need to give this kind of UI change quite a bit more thought to ensure that it is clear to users, so we won't be adding this functionality at the moment. Please keep providing your feedback though ⚡

@jf205 jf205 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
@jf205 jf205 removed their assignment Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request VSCode
Projects
None yet
Development

No branches or pull requests

2 participants