Skip to content

Golang: Change HTTP ClientRequest type to DataFlow::CallNode #184

Discussion options

You must be logged in to vote

I'm not sure. I think keeping the more general type has its advantage, just in case we end up wanting to model an API where the client request isn't actually a call. Note that you can use postfix casts to suppress most of the syntactic noise:

exists(HTTP::ClientRequest req | sink = req.(DataFlow::CallNode).getAnArgument())

Longer term, I think it would be worth considering introducing a member predicate on HTTP::ClientRequest that does what you are using getAnArgument() for here, though I'm not entirely sure what that is.

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by jason-invision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants