Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent layout type for GitHub Actions pages #35217

Closed
1 task done
akordowski opened this issue Nov 7, 2024 · 4 comments
Closed
1 task done

Inconsistent layout type for GitHub Actions pages #35217

akordowski opened this issue Nov 7, 2024 · 4 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@akordowski
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

Reading the GitHub Actions documentation I have noticed that only 4 pages have an layout: inline type, where other pages don't have any layout type. Is that intentional or can be this seen as a bug?

The pages are:

What part(s) of the article would you like to see updated?

Remove the layout: inline type to have a consistent layout type for GitHub Actions pages.

Additional information

No response

@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Nov 7, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 7, 2024
@akordowski
Copy link
Contributor Author

akordowski commented Nov 7, 2024

I made a search in the /content/**/*.md files and there are 17 files in total that have the layout: inline type. It affects also other pages as well.

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Nov 7, 2024
@nguyenalex836
Copy link
Contributor

@akordowski Thank you for raising this issue! I'll get this triaged for review ✨ Our team will assess the layout: inline type currently present, and provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@nguyenalex836
Copy link
Contributor

@akordowski Thank you for raising this issue! ✨ We checked in with the original authors of this doc, and they stated layout: inline was deliberate to avoid a table rendering poorly 💛

Thank you very much for discussing with us before raising the PR! We appreciate your contributions to our community 🙇

@akordowski
Copy link
Contributor Author

akordowski commented Nov 8, 2024

Ok, I see. This page contains indeed a large table. but what about the other pages? As I have seen some of them could be aligned with the default layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

2 participants