Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload repos with many -- in repo name if alternate_title exists #96

Open
eshellman opened this issue Mar 1, 2016 · 2 comments
Open

Comments

@eshellman
Copy link
Contributor

suggested by @tfmorris: in #77
there is no reason not to use the alternative title in this case, since it's available:

https://github.com/GITenberg/------------------------------------------------------------13--------------------------_31434/blob/master/pg31434.rdf#L39

invesitigate something like https://pypi.python.org/pypi/transliterate/1.7.6

@tfmorris
Copy link
Contributor

Did this turn out to be too hard to do? There's a commit that references this issue, but repo in the original issue still exists with the same name and, as far as I can tell, there's no better named version. That book also appears to be unfindable on the web site.

@eshellman
Copy link
Contributor Author

This was implemented for new ebooks, so roughly #45000+. Thanks for the help.

A small number of of old repos have been renamed. This turned out to be really messy, because name skew broke things in the update chain. The code now depends on a lookup table which has to be frequently updated so that repo names don't changed when title metadata changes, which happens more often than you would think. For the PG implementation effort, we'll definitely NOT use anything other than book numbers in the repo names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants