Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backgroundPositions should concatenate values without a comma #277

Open
TomiS opened this issue Nov 13, 2023 · 1 comment
Open

backgroundPositions should concatenate values without a comma #277

TomiS opened this issue Nov 13, 2023 · 1 comment

Comments

@TomiS
Copy link
Contributor

TomiS commented Nov 13, 2023

At the moment

CssJs.backgroundPositions([#right, #top])

produces CSS

background-position: right, top;

I believe it should concatenate the values without a comma like this

background-position: right top;
@giraud
Copy link
Owner

giraud commented Nov 17, 2023

You can have comma if you position multiple backgrounds (from mdn):

image

but, maybe it should be a list of list instead.
It would be great if you can add a PR for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants