Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while upgrading to rescript >=10 #265

Open
davisuga opened this issue Feb 10, 2023 · 3 comments
Open

Error while upgrading to rescript >=10 #265

davisuga opened this issue Feb 10, 2023 · 3 comments

Comments

@davisuga
Copy link

When I update the rescript version, the pipeline breaks while compiling bs-css.

Dependency on bs-css
07:21:38.090 | rescript: [1/21] src/Css_Core.ast
07:21:38.094 | rescript: [2/21] src/Css_Colors.ast
07:21:38.098 | rescript: [3/21] src/Css_Js_Core.ast
07:21:38.104 | rescript: [4/21] src/Css_Js_Core.iast
07:21:38.105 | rescript: [5/21] src/Css_AtomicTypes.ast
07:21:38.106 | rescript: [6/21] src/Css_Core.d
07:21:38.108 | rescript: [7/21] src/Css_Colors.d
07:21:38.109 | rescript: [8/21] src/Css_AtomicTypes.iast
07:21:38.110 | rescript: [9/21] src/Css_Js_Core.d
07:21:38.126 | rescript: [10/21] src/Css_AtomicTypes.d
07:21:38.134 | rescript: [11/21] src/Css_Legacy_Core.ast
07:21:38.142 | rescript: [12/21] src/Css_Legacy_Core.iast
07:21:38.145 | rescript: [13/21] src/Css_Core.cmj
07:21:38.146 | rescript: [14/21] src/Css_Legacy_Core.d
07:21:38.166 | rescript: [15/21] src/Css_AtomicTypes.cmi
07:21:38.225 | rescript: [16/21] src/Css_Js_Core.cmi
07:21:38.258 | rescript: [17/21] src/Css_Legacy_Core.cmi
07:21:38.272 | rescript: [18/21] src/Css_AtomicTypes.cmj
07:21:38.341 | rescript: [19/21] src/Css_Colors.cmj
07:21:38.447 | rescript: [20/21] src/Css_Legacy_Core.cmj
07:21:38.480 | rescript: [21/21] src/Css_Js_Core.cmj
07:21:38.494 | rescript: [1/27] Css_Core.cmi
07:21:38.496 | rescript: [2/27] Css_Core.cmj
07:21:38.496 | rescript: [3/27] Css_Core.cmt
07:21:38.498 | rescript: [4/27] Css_Core.res
07:21:38.499 | rescript: [5/27] Css_Colors.cmi
07:21:38.502 | rescript: [6/27] Css_Colors.cmj
07:21:38.505 | rescript: [7/27] Css_Colors.cmt
07:21:38.506 | rescript: [8/27] Css_Colors.res
07:21:38.508 | rescript: [9/27] Css_Js_Core.cmi
07:21:38.509 | rescript: [10/27] Css_Js_Core.cmj
07:21:38.511 | rescript: [11/27] Css_Js_Core.cmt
07:21:38.512 | rescript: [12/27] Css_Js_Core.res
07:21:38.513 | rescript: [13/27] Css_Js_Core.resi
07:21:38.515 | rescript: [14/27] Css_AtomicTypes.cmi
07:21:38.516 | rescript: [15/27] Css_Js_Core.cmti
07:21:38.518 | rescript: [16/27] Css_AtomicTypes.cmt
07:21:38.521 | rescript: [17/27] Css_AtomicTypes.cmj
07:21:38.521 | rescript: [18/27] Css_AtomicTypes.res
07:21:38.525 | rescript: [19/27] Css_AtomicTypes.resi
07:21:38.526 | rescript: [20/27] Css_AtomicTypes.cmti
07:21:38.528 | rescript: [21/27] Css_Legacy_Core.cmi
07:21:38.528 | rescript: [22/27] Css_Legacy_Core.cmj
07:21:38.528 | rescript: [23/27] Css_Legacy_Core.cmt
07:21:38.529 | rescript: [24/27] Css_Legacy_Core.res
07:21:38.529 | rescript: [25/27] Css_Legacy_Core.resi
07:21:38.531 | rescript: [26/27] install.stamp
07:21:38.531 | rescript: [27/27] Css_Legacy_Core.cmti
07:21:38.532 | Dependency on bs-css-emotion
07:21:38.532 | Different compiler version: clean current repo
07:21:38.534 | Cleaning... 28 files.
07:21:38.538 | Cleaning... 10 files.
07:21:38.563 | rescript: [1/6] src/Css.ast
07:21:38.563 | rescript: [2/6] src/CssJs.ast
07:21:38.565 | rescript: [3/6] src/Css.d
07:21:38.566 | rescript: [4/6] src/CssJs.d
07:21:38.575 | rescript: [5/6] src/Css.cmj
07:21:38.575 | FAILED: src/Css.cmj
07:21:38.575 |  
07:21:38.575 | We've found a bug for you!
07:21:38.575 | /vercel/path0/dapp/node_modules/.pnpm/bs-css-emotion@2.5.1/node_modules/bs-css-emotion/src/Css.re:1:9-23
07:21:38.575 |  
07:21:38.575 | 1include Css_Legacy_Core;
07:21:38.575 | 2include Css_Colors;
07:21:38.575 | 307:21:38.575 |  
07:21:38.575 | The module or file Css_Legacy_Core can't be found.
07:21:38.575 | - If it's a third-party dependency:
07:21:38.575 | - Did you list it in bsconfig.json?
07:21:38.575 | - Did you run `rescript build` instead of `rescript build -with-deps`
07:21:38.576 | (latter builds third-parties)?
07:21:38.576 | - Did you include the file's directory in bsconfig.json?
07:21:38.576 |  
07:21:38.579 | rescript: [6/6] src/CssJs.cmj
07:21:38.579 | FAILED: src/CssJs.cmj
07:21:38.579 |  
07:21:38.579 | We've found a bug for you!
07:21:38.579 | /vercel/path0/dapp/node_modules/.pnpm/bs-css-emotion@2.5.1/node_modules/bs-css-emotion/src/CssJs.re:1:9-19
07:21:38.579 |  
07:21:38.579 | 1include Css_Js_Core;
07:21:38.579 | 2include Css_Colors;
07:21:38.579 | 307:21:38.579 |  
07:21:38.579 | The module or file Css_Js_Core can't be found.
07:21:38.579 | - If it's a third-party dependency:
07:21:38.580 | - Did you list it in bsconfig.json?
07:21:38.580 | - Did you run `rescript build` instead of `rescript build -with-deps`
07:21:38.580 | (latter builds third-parties)?
07:21:38.580 | - Did you include the file's directory in bsconfig.json?
07:21:38.580
@giraud
Copy link
Owner

giraud commented Feb 10, 2023

ok, bs-css can be built but not the dependencies. is rescript 10 supposed to work with yarn workspaces ?

@davisuga
Copy link
Author

We use pnpm workspaces and rescript 10 is working in other packages

@mcharnet
Copy link

mcharnet commented Jan 8, 2024

Hi @davisuga, did you find a solution for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants