Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.4.5 PHP 8.1 - Cannot save Gigya Settings #135

Open
mtwegrzycki opened this issue Feb 6, 2023 · 3 comments
Open

Magento 2.4.5 PHP 8.1 - Cannot save Gigya Settings #135

mtwegrzycki opened this issue Feb 6, 2023 · 3 comments

Comments

@mtwegrzycki
Copy link

System:
Magento: 2.4.5-p1 and we updated PHP to version 8.1.
PHP: 8.1
gigya/magento2-im: 6.0.0

Issue description
When we try to save Gigya's new settings in Magento Admin Panel, we got the following error:
image

We discovered that in the following class vendor/gigya/magento2-im/Helper/CmsStarterKit/GigyaApiHelper.php in line 388, Gigya provides null as a parameter:
image

PHP 8.1 requires integer (0) for this case:
image

Possible solution:
When we temporary set 0 instead of null for enc method, it works correctly and we were able to save configuration in Magento Admin Panel, but it is file in vendor, so we should not modify any files there

Question:
Please, let me know, if it is issue on Gigya side or something is incorrect with our configuration/setup.
If issue is on Gigya side, please let me what is recommended solution, or do you plan any fix for this case?

@Ynhockey
Copy link
Collaborator

Hi, as far as I remember, the idea was indeed to use the default value that openssl_encrypt provides. We will verify this and modify it in the next version, assuming it works.

@mtwegrzycki
Copy link
Author

Hi

@Ynhockey , please tell me, if you have any update on this?

@Ynhockey
Copy link
Collaborator

Hi @mtwegrzycki , I have verified that it works, but we haven't released a new version yet because we'd like to fully support the latest versions of PHP and Magento 2. I can confirm though that this modification in openssl_encrypt works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants