Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROOF server "running" contextualization #9

Open
vortexing opened this issue Oct 2, 2024 · 2 comments · May be fixed by FredHutch/shiny-cromwell#163
Open

PROOF server "running" contextualization #9

vortexing opened this issue Oct 2, 2024 · 2 comments · May be fixed by FredHutch/shiny-cromwell#163

Comments

@vortexing
Copy link
Member

When you click " start proof server" it nearly instantly says "Job Status: RUNNING". but that really means that the process to create a server is running NOT the server itself. IF the server itself is running then the "Current PROOF server info" should be available.
Screenshot 2024-10-02 at 10 11 49 AM

Another issue I'm running into every time is basically at some point we should be polling to see if the API from the started server is receiving input and responding b/c it's delayed even once your server gets a job on a node. THEN if a basic API call comes back successful, THEN we should say, "PROOF server is Running".

Just my 2 cents.

@vortexing
Copy link
Member Author

Yeah, now my proof server appears to be running but yet I can't get a response on the other tab.
Screenshot 2024-10-02 at 10 16 08 AM

When you're using proof, the user, IMHO expects that if "it's running" then functions on all tabs should work. However that delay for the difference between the server running and the API actually working so all the tabs work, should be invisible to the user. Don't tell them it's working if the part of it that they care about is not yet working. ;)

@sckott
Copy link
Member

sckott commented Oct 8, 2024

Thanks. This should be fixed on dev branch.

@tefirman tefirman linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants