Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for assembly definitions and native binaries include all platforms #1962

Open
AndrewCarvalho opened this issue Jan 11, 2025 · 1 comment

Comments

@AndrewCarvalho
Copy link

Environment

How do you use Sentry?
Unknown, not relevant

Which version of the SDK?
Unknown, not relevant

How did you install the package?
Git url

Which version of Unity?
2021.3.38

Is this happening in Unity (editor) or on a player like Android, iOS, Windows?
Player

Steps to Reproduce

  1. Build for an unsupported platform (Most platforms, error was first found on PS5)
  2. Run the build until something is logged by sentry

Expected Result

Sentry assemblies should not be included or have empty stubs for unsupported platforms

Actual Result

Runtime errors when trying to call into sentry methods.

Solution

Due to git packages not being editable, The default settings where assemblies are included for all platforms by default can't be changed without embedding the package into the project.

Ideally, the assemblies should not have All Platforms enabled and instead only enable explicitly supported platforms.

@bitsandfoxes
Copy link
Contributor

Hey @AndrewCarvalho, thanks for raising this. I'll update the asmdefs accordingly. That was an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants