Bundling with @sentry/[email protected] no longer outputs .node files, 8.47.0 does

[rgripper]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

8.39.0

Framework Version

No response

Link to Sentry event

No response

Reproduction Example/SDK Setup

No response

Steps to Reproduce

@sentry/[email protected]
esbuild (or bun) no longer outputs *.node binaries with my instrument.js using

  loader: {
    // ensures .node binaries are copied to ./dist
    ".node": "copy",
  },

But @sentry/[email protected] works fine

Expected Result

the output folder contains multiple *.node binaries and instrument.js

Actual Result

the output folder contains only instrument.js

[s1gr1d]

Hello, thanks for reaching out! This bug was most likely introduced in this PR: #14952
I was able to reproduce it and we're on it to fix this!

For now, you can downgrade to 8.48.0 or try to copy the node binaries from node_modules/@sentry/profiling-node/lib

[s1gr1d]

For more context: esbuild does not support createRequire and there is an open issue for this: evanw/esbuild#1828

As node-based libraries were not instrumented with Sentry correctly when using them together with profiling, this PR was added to fix this: #14470 (released with 8.49.0).
This PR basically removes storing require etc. on globalThis as this was the root-cause of a set of problems. However, storing those variables on globalThis is also one of the proposed short-term solutions in esbuild to support ESM and CJS: evanw/esbuild#1921 (comment)