Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Prisma v6 #14793

Open
AbhiPrasad opened this issue Dec 18, 2024 · 7 comments
Open

Support Prisma v6 #14793

AbhiPrasad opened this issue Dec 18, 2024 · 7 comments
Assignees
Labels
Feature: Spans Integration: prisma Issues related to Prisma support for the Sentry Node SDK Package: node Issues related to the Sentry Node SDK
Milestone

Comments

@AbhiPrasad
Copy link
Member

Description

From: getsentry/sentry-docs#12184

Prisma launched new version of 6.1.0 where tracing is not in previewFeature and some additional things need to be done to be able to trace application. Docs need to be updated

https://github.com/prisma/prisma/releases/tag/6.1.0

On our side we've been evaluating merging in #14624 for v9 (considering it seems to be a breaking change in some ways).

We need to figure out:

  1. Can we merge in 6.x bump for prisma instrumentation and still support 5.x? Ideally we can figure out how to support both at the same time so we support the max amount of users.
  2. How do we structure the docs (this issue: Outdated prisma documentation sentry-docs#12184) to make both 5.x and 6.x of the prisma integration work with 8.x and 9.x of the SDK.
@AbhiPrasad AbhiPrasad added Feature: Spans Integration: prisma Issues related to Prisma support for the Sentry Node SDK Package: node Issues related to the Sentry Node SDK labels Dec 18, 2024
@AbhiPrasad AbhiPrasad added this to the 9.0.0 milestone Dec 18, 2024
Stormix added a commit to Stormix/deadlock-modmanager that referenced this issue Dec 28, 2024
@mydea
Copy link
Member

mydea commented Jan 10, 2025

related: #14973

@AbhiPrasad AbhiPrasad self-assigned this Jan 13, 2025
@AbhiPrasad
Copy link
Member Author

In terms of supporting both versions we have the following options.

  1. Only support 6.x for the upcoming v9 Sentry SDK. If folks want to use 5.x they can opt-in themselves by installing the package and flipping a flag in the integration.
  2. Support both 5.x and 6.x and conditionally switch for people. This means we have to include @prisma/instrumentation 5.x and 6.x as dependencies though :/
  3. Keep only supporting 5.x even in the upcoming v9 Sentry SDK. If folks want to use 6.x they can opt-in themselves by installing the package and flipping a flag in the integration.

Still debating through this, it's a little annoying that prisma instrumentation has such hard version constraints. I wish they separated it from the rest of prisma semvar.

All 3 approaches should be easy, but 1 and 3 will require the most possible manual work from users. 2 is all automatic, but we keep the deps for a while.

@AbhiPrasad
Copy link
Member Author

Updated our docs to make it clear that the SDK only supports 5.x atm: getsentry/sentry-docs#12324

@AbhiPrasad
Copy link
Member Author

Decision:

For v9 we are going to go ahead with 6.x support. We'll support 5.x in v8 and in v9 via a prismaIntegration(PrismaInstrumentationClass) API

@aried3r
Copy link

aried3r commented Jan 14, 2025

@AbhiPrasad, to clarify. v8 supports 6.0.x of prisma, but not > 6.1, correct?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 14, 2025
@AbhiPrasad
Copy link
Member Author

@aried3r I haven't tested out v8 with 6.0.x, I only started to test with 6.1.x and above.

I think we'll officially say that only 5.x is supported with v8 (so that's what we run the test suite against).

@mydea
Copy link
Member

mydea commented Jan 15, 2025

Just leaving this here too because it was not obvious to me: Starting in v6 of Prisma, no client config is needed anymore, meaning tracing will work out of the box 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Spans Integration: prisma Issues related to Prisma support for the Sentry Node SDK Package: node Issues related to the Sentry Node SDK
Projects
Status: No status
Development

No branches or pull requests

3 participants