Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not derive {{auto}} IPs when toggle is off #4431

Open
jjbayer opened this issue Jan 8, 2025 · 1 comment
Open

Do not derive {{auto}} IPs when toggle is off #4431

jjbayer opened this issue Jan 8, 2025 · 1 comment
Labels
filler Requires little effort to resolve. Ready to be picked up anytime.

Comments

@jjbayer
Copy link
Member

jjbayer commented Jan 8, 2025

The project setting "Prevent storing of IP addresses" is currently implemented by IP scrubbing. To be on the safe side, we should not even convert {{ auto }} IPs to actual IPs if this setting is enabled.

Image

/// When `{{auto}}` is specified and there is no other IP address in the payload, such as in the
/// `request` context, this IP address gets added to the `user` context.
pub client_ip: Option<&'a IpAddr>,

@jjbayer jjbayer changed the title Do not derive {{ auto }} IPs when toggle is off Do not derive {{auto}} IPs when toggle is off Jan 8, 2025
@olksdr olksdr added the filler Requires little effort to resolve. Ready to be picked up anytime. label Jan 13, 2025
@Dav1dde
Copy link
Member

Dav1dde commented Jan 13, 2025

Turns out we have 3 platforms for which {{auto}} inference is ignored, maybe instead, or additional, we introduce {{auto}} to these SDKs and platforms and after a reasonable migration period we drop this exception from Relay:

if user.ip_address.value().is_none() {
// In an ideal world all SDKs would set {{auto}} explicitly.
if let Some("javascript") | Some("cocoa") | Some("objc") = platform {
user.ip_address = Annotated::new(client_ip.to_owned());
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filler Requires little effort to resolve. Ready to be picked up anytime.
Projects
None yet
Development

No branches or pull requests

3 participants