-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Migration] i18n_subsites #1349
Comments
I'd like to get involved here, too. How can I help? |
I use the i18n_subsites plugin for my blog and would like to help with the migration. Can anybody chime in about what work needs to be done? @justinmayer? |
Its all documented here: https://blog.getpelican.com/namespace-plugin-migration.html |
Thank you @georgkrause. So from https://blog.getpelican.com/namespace-plugin-migration.html it looks like we stand at the very beginning:
If one of the maintainers could create a reop for |
I am swamped at the moment but will endeavor to kick-start the migration process sometime this month. Thanks to everyone for their patience and understanding! |
But why? |
Thank you for getting back to us @justinmayer, just let us know when it is ready.
Upgrading pelican broke my site so I assumed that was the issue, but maybe it's something else. I will debug it, thank you for the heads up @avaris. |
@justinmayer Any news about this? |
I filtered the subdirectory in its own repository: https://github.com/georgkrause/i18n_subsites I am willing to transfer the project, just let me know! |
As far as I can tell there are 6 open merge requests regarding i18n_subsites, I will try to review them in the next days and merge them into my fork. |
@georgkrause thanks. feel free to ping me if you need any help with testing. I don't have much free time, and I might already used a very customized pelican to get my i18n site working, but I will try to help. |
@adiroiban Jeah for me its almost the same, which is why I want to cleanup the situation. I cannot stand pulling a huge set of submodules and patching them to make it work any longer. It would be nice if you would use my fork as well, what needs to be merged to make this possible for you? So I can start with reviewing this first. |
Thanks George for the work. But definitively, next time I will work on the project in which pelican i18n is used, I will switch to use your fork... that I hope will grow into de-facto plugin. I did a quick copy/paste for my fork https://gist.github.com/adiroiban/2019f82cc6b6a335ffdd93a06e7143cc |
Do I get this right? This is a dump of what you have running in production? This helps a lot, lets integrate this :) |
I think there are 2 main changes in my fork. First is this change for which I have already created a PR #1350 The second one, is support for gettext inside the main SITE dict... but maybe I am wrong and this is already standard functionality.
|
@adiroiban @georgkrause @haplo https://pypi.org/project/pelican-i18n-subsites The project repository currently sits here: https://github.com/rschiang/pelican-i18n-subsites. Could you help verify if it works as expected, so we can ask @justinmayer to move it into @pelican-plugins and make us maintainers? 👀 |
Hi. Sorry for the delay. At work, we don't yet have a multi-lingual website, it was more of an experiment, Once this goes into production I will check your repo. I started it and I hope I will not forget about it :) Thanks for putting this all together. |
Let me close this as all work should be done in the separate repo. |
It would be nice to have the i18n_subsites plugin move it's own repo.
I can help with the migration.
When doing the migration please also consider moving the issues.
Not sure what to do with the existing pull requests
I some PR for i18n are great contribution, yet they were not approved (since 2017)[https://github.com//pull/841]
Thanks!
The text was updated successfully, but these errors were encountered: