Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity data overflows hover card when value of property contains long word #854

Closed
matthew-white opened this issue Dec 18, 2024 · 3 comments · Fixed by getodk/central-frontend#1115
Assignees
Labels
behavior verified Behavior has been manually verified bug entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

From @dbemke at #670 (comment):

After editing an entity with a long name, the hover card in submission detail page is broken (wrong width of property name, entered values are show beyond the hover card.
https://staging.getodk.cloud/#/projects/97/forms/trees_registration/submissions/uuid%3A2d68092f-0d00-4123-b98a-b87f8c19f9f8
Image

Steps to reproduce:

  1. Go to the Entities "Data” tab.
    https://staging.getodk.cloud/#/projects/97/entity-lists/trees/entities
  2. Click "More”.
  3. In the detail page click "Edit”.
  4. In e.g. circumference_cm field enter a long name/number and update the entity.
  5. In the "Activity” part click the hyperlink to the submission.
  6. Hover over the "Created entity” hyperlink.
@matthew-white matthew-white added bug frontend Requires a change to the UI needs testing Needs manual testing labels Dec 18, 2024
@matthew-white matthew-white self-assigned this Dec 18, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Dec 18, 2024
@matthew-white
Copy link
Member Author

It looks like the issue doesn't always happen when the value of an entity property is long. In getodk/central-frontend#1110, I tested the value "54.6029931 18.2311011 72.70000457763672 23.649", and I saw that it wrapped and was truncated as expected. It looks like the issue happens specifically when the value contains a particularly long word or number. It's more about long words than just long values.

matthew-white added a commit to getodk/central-frontend that referenced this issue Dec 19, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Dec 19, 2024
@matthew-white matthew-white added the entities Multiple Encounter workflows label Dec 19, 2024
lognaturel pushed a commit to getodk/central-frontend that referenced this issue Dec 19, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Dec 19, 2024
@lognaturel
Copy link
Member

@dbemke thé fix for this should be on staging!

@dbemke
Copy link

dbemke commented Dec 19, 2024

Tested with success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified bug entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

3 participants