From 05481b582cd47245847b0f0b0178ba0438de71cc Mon Sep 17 00:00:00 2001 From: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Date: Wed, 11 Sep 2024 18:45:10 +0200 Subject: [PATCH 1/2] refactor: Update Contributing doc --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3a2a569d9..acfe6f791 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,7 +33,7 @@ If you know these technologies or would like to learn them, lucky you! This is t 4. run `go install github.com/joho/godotenv/cmd/godotenv` to install godotenv, a cli tool to load environment variables from a `.env` so that you don't have to change your machine environment variables. 5. run `go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1` to install golangci-lint, a linter for Go apps. 6. run `npm install` to install client side packages. -7. run `docker-compose up -d` to start a local PostgreSQL database and Local SMTP (with [MailHog](https://github.com/mailhog/MailHog)) on Docker. +7. run `docker compose up -d` to start a local PostgreSQL database and Local SMTP (with [MailHog](https://github.com/mailhog/MailHog)) on Docker. 8. run `cp .example.env .env` to create a local environment configuration file. - **Important:** Fider has a strong dependency on an email delivery service. For easier local development, the docker-compose file already provides From ea28569cc4af606d9e7245a1dafd903e752207ef Mon Sep 17 00:00:00 2001 From: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Date: Wed, 11 Sep 2024 19:49:43 +0200 Subject: [PATCH 2/2] refactor: Update broken link in Makefile --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index aeb0bc9cf..ed69180ed 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ ## This is a self-documented Makefile. For usage information, run `make help`: ## -## For more information, refer to https://suva.sh/posts/well-documented-makefiles/ +## For more information, refer to https://www.thapaliya.com/en/writings/well-documented-makefiles/ LDFLAGS += -X github.com/getfider/fider/app/pkg/env.commithash=${COMMITHASH}