Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a proper tooltip for the Metadata Quality widget #819

Open
jahow opened this issue Mar 11, 2024 · 0 comments
Open

Use a proper tooltip for the Metadata Quality widget #819

jahow opened this issue Mar 11, 2024 · 0 comments
Labels
feature request A suggestion or request (not a proposal)
Milestone

Comments

@jahow
Copy link
Collaborator

jahow commented Mar 11, 2024

Description

The Metadata Quality widget currently shows a popover with details on how the quality indicator is computed:

image

This popover is not a "real" popover in that it isn't showing on top of everything else, but simply appended to its parent element. This has been shown to produce issues when this component is used in other contexts, e.g. having scrollbars show up etc. (this can notably be the case for custom apps)

An improvement would be to use a shared popover component in the project, which would give:

  • no unexpected layout issues
  • better "standardized" styling for the popover
  • less code in the actual metadata-quality component

Motivation

Issues were encountered in the MEL custom app worked on by Camptocamp.

Inspiration and context

The tippy library is great for handling popovers and is already used in the project for the "favorite star" tooltip:
image

This library should probably be encapsulated in a shared ui-layout component which would be used both by the favorite star toggle and the metadata quality widget.

@jahow jahow added the feature request A suggestion or request (not a proposal) label Mar 11, 2024
@jahow jahow added this to the 2.4.0 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A suggestion or request (not a proposal)
Projects
None yet
Development

No branches or pull requests

1 participant